Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination connector for teradata vantage (rebased community PR) #21160

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

grishick
Copy link
Contributor

@grishick grishick commented Jan 9, 2023

What

Rebased version of this PR: #20428

@grishick grishick requested a review from a team as a code owner January 9, 2023 16:29
@octavia-squidington-iv octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/teradata labels Jan 9, 2023
@grishick grishick temporarily deployed to more-secrets January 9, 2023 16:30 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets January 9, 2023 16:30 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (1)

Connector Version Changelog Publish
destination-teradata 0.1.0
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@grishick grishick force-pushed the greg/teradata-vantage branch from 855d194 to 26cfb8d Compare January 9, 2023 17:43
@grishick grishick temporarily deployed to more-secrets January 9, 2023 17:45 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets January 9, 2023 17:45 — with GitHub Actions Inactive
@grishick
Copy link
Contributor Author

grishick commented Jan 9, 2023

/test connector=connectors/destination-teradata

🕑 connectors/destination-teradata https://github.com/airbytehq/airbyte/actions/runs/3876592483
✅ connectors/destination-teradata https://github.com/airbytehq/airbyte/actions/runs/3876592483
No Python unittests run

Build Passed

Test summary info:

All Passed

@grishick
Copy link
Contributor Author

grishick commented Jan 9, 2023

/publish connector=connectors/destination-teradata

🕑 Publishing the following connectors:
connectors/destination-teradata
https://github.com/airbytehq/airbyte/actions/runs/3876747718


Connector Did it publish? Were definitions generated?
connectors/destination-teradata

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grishick
Copy link
Contributor Author

grishick commented Jan 9, 2023

/publish connector=connectors/destination-teradata

🕑 Publishing the following connectors:
connectors/destination-teradata
https://github.com/airbytehq/airbyte/actions/runs/3877869024


Connector Did it publish? Were definitions generated?
connectors/destination-teradata

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grishick grishick force-pushed the greg/teradata-vantage branch from 26cfb8d to 5d1c0ff Compare January 10, 2023 00:57
@grishick grishick temporarily deployed to more-secrets January 10, 2023 00:59 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets January 10, 2023 01:00 — with GitHub Actions Inactive
@grishick
Copy link
Contributor Author

/approve-and-merge reason=”These changes were already approved in the original PR #20428"

@octavia-approvington
Copy link
Contributor

This is really good
simply the best

@octavia-approvington octavia-approvington merged commit 1ed04fd into master Jan 10, 2023
@octavia-approvington octavia-approvington deleted the greg/teradata-vantage branch January 10, 2023 16:41
@grishick grishick mentioned this pull request Jan 10, 2023
37 tasks
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
…1160)

* Destination connector for teradata vantage is implemented

* add teradata destination to seed yaml

* Add teradata destination to specs seed file

Co-authored-by: Satish Chinthanippu <satishchinthanippu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/teradata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants